Repository navigation
fix(auth): remove unneeded OAuth flows - #5353
patrasap0908 wants to merge 4 commits into
Conversation
d75c56f to
f81270d
Compare
|
Hi @patrasap0908 , Thank you for your contribution through this pull request! This PR has merge conflicts that require changes from your end. Could you please rebase your branch with the latest main branch to address these? Once this is complete, please let us know so we can proceed with the review. |
Done @rohityan, please take a look now. |
|
Hi @patrasap0908 , can you please resolve the conflicts. |
|
Not needed anymore, this should be fixed in the next couple of days. |
Related issue
Problem
During agent invocation, OAuth redirection happens for every toolset (that returns an
AuthConfig) regardless of whether the user message requires tool invocation or not.Solution
This PR defers the OAuth flow to tool invocation time, which already works as expected.
Testing plan
Unit tests
End-to-end test results:
Checklist
Additional context
Since
_resolve_toolset_auth()will simply defer auth flows to tool invocation time, there is no need to handle the topic of framework- and tool-level credential file path mismatch in this PR. Once consensus is reached, a separate PR can be opened for it later.