Repository navigation
fix(cli): normalize trigger user ids for sessions - #5402
MukundaKatta wants to merge 2 commits into
Conversation
|
Response from ADK Triaging Agent Hello @MukundaKatta, thank you for creating this PR! This PR is a bug fix, could you please associate the github issue with this PR? If there is no existing issue, could you please create one? This information will help reviewers to review your PR more efficiently. Thanks! |
b7b1fc5 to
6414053
Compare
rohityan
added
the
request clarification
|
Hi @MukundaKatta , Thank you for your contribution through this pull request! This PR has merge conflicts that require changes from your end. Could you please rebase your branch with the latest main branch to address these? Once this is complete, please let us know so we can proceed with the review. |
aa3a9e7 to
c4396ec
Compare
|
@rohityan rebased onto latest main. Conflict in |
rohityan
added
needs review
|
Hi @Jacksunwei , can you please review this. |
Merge #5402 ## Summary - normalize Pub/Sub subscription and Eventarc source metadata before reusing them as session user ids - replace slash-separated resource paths with path-safe -- delimiters while preserving the full resource identity - add trigger endpoint regression tests that verify the created sessions are stored under the normalized user ids ## Testing - python3 -m py_compile src/google/adk/cli/trigger_routes.py tests/unittests/cli/test_trigger_routes.py - python3 -m pytest tests/unittests/cli/test_trigger_routes.py -k "path_safe or with_subscription_metadata or source_from_ce_header" (fails during collection in this environment: ModuleNotFoundError: No module named 'fastapi') Co-authored-by: George Weale <gweale@google.com> COPYBARA_INTEGRATE_REVIEW=#5402 from MukundaKatta:codex/trigger-user-id-path-safe a974679 PiperOrigin-RevId: 963505905
|
Thank you @MukundaKatta for your contribution! 🎉 Your changes have been successfully imported and merged via Copybara in commit e03dbab. Closing this PR as the changes are now in the main branch. |
Summary
Testing