Repository navigation
fix(tools): handle missing 'request' key in AgentTool.run_async fallb… - #5678
Closed
phinglaspure123 wants to merge 8 commits into
Closed
phinglaspure123 wants to merge 8 commits into
phinglaspure123 wants to merge 8 commits into
Conversation
Collaborator
|
Hi @phinglaspure123 , Thank you for your contribution! We appreciate you taking the time to submit this pull request. Your PR has been received by the team and is currently under review. We will provide feedback as soon as we have an update to share. |
Collaborator
|
Hi @sasha-gitg , can you please review this. |
Collaborator
|
Thank you @phinglaspure123 for your contribution! 🎉 Your changes have been successfully imported and merged via Copybara in commit 8b09c48. Closing this PR as the changes are now in the main branch. |
FrigaZzz
pushed a commit
to FrigaZzz/adk-python
that referenced
this pull request
Aug 11, 2026
Merge google#5678 Closes google#1084 (KeyError half — the AttributeError half was fixed Nov 2025) Co-authored-by: Xuan Yang <xygoogle@google.com> COPYBARA_INTEGRATE_REVIEW=google#5678 from phinglaspure123:fix/agent-tool-keyerror-request 67b3187 PiperOrigin-RevId: 933288076
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
AgentToolwraps an agent with noinput_schema,run_asyncfalls back to: