Repository navigation
Conversation
…esults and FieldValue
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the BigQuery client to propagate the full DataFormatOptions (including timestamp output format) instead of just a boolean useInt64Timestamps flag across BigQueryImpl, BigQueryOptions, FieldValue, FieldValueList, and HttpBigQueryRpc. Additionally, it optimizes timestamp parsing in FieldValue.getTimestampValue() by using Long.parseLong instead of allocating a BigInteger when useInt64Timestamps is enabled. Unit tests have been updated and a new test has been added to verify the propagation of these options to RPC requests. There are no review comments to address, and I have no further feedback to provide.
| this.attribute = checkNotNull(attribute); | ||
| this.value = value; | ||
| this.useInt64Timestamps = useInt64Timestamps; | ||
| this.useInt64Timestamps = dataFormatOptions != null && dataFormatOptions.useInt64Timestamp(); |
There was a problem hiding this comment.
It would be possible for users to set TimestampFormatOptions.INT64 without setting useInt64Timestamp(true), right? Would it make sense to account for such cases?
There was a problem hiding this comment.
It would be possible for users to set TimestampFormatOptions.INT64 without setting useInt64Timestamp(true), right?
I'm not sure I follow this. What do you mean set it without useInt64Timestamp(true)
This branch has not been deployed
2 participants
No description provided.