Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request temporarily disables the ITAppendableUploadTest integration test class by adding the @Ignore annotation because PROD runs exceed the Kokoro timeout. The review feedback correctly identifies a missing import for org.junit.Ignore that would cause a compilation error and provides a code suggestion to resolve it.
Comment on lines
+57
to
+60
| import org.junit.Test; | ||
| import org.junit.runner.RunWith; | ||
|
|
||
| @Ignore("Temporarily disabled: PROD runs exceed the Kokoro timeout. Re-enable once fixed.") |
Contributor
There was a problem hiding this comment.
The @Ignore annotation is used here, but org.junit.Ignore is not imported in this file. This will cause a compilation error. Please add the import statement for org.junit.Ignore.
Suggested change
| import org.junit.Test; | |
| import org.junit.runner.RunWith; | |
| @Ignore("Temporarily disabled: PROD runs exceed the Kokoro timeout. Re-enable once fixed.") | |
| import org.junit.Ignore; | |
| import org.junit.Test; | |
| import org.junit.runner.RunWith; | |
| @Ignore("Temporarily disabled: PROD runs exceed the Kokoro timeout. Re-enable once fixed.") |
…tral1-a Re-enable ITAppendableUploadTest, move the RAPID test bucket to us-central1-a, and temporarily ignore takeoverAndAppendWithIncorrectChecksumFails.
Dhriti07
marked this pull request as ready for review
October 21, 2026 15:04
nidhiii-27
approved these changes
Oct 21, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The RAPID test bucket's zone (us-central1-c) has run out of Rapid storage (rapid_zonal_bytes) quota for the CI project. Every PROD appendable upload fails with RESOURCE_EXHAUSTED after a 50s retry, so the Storage Integration job runs past the Kokoro timeout.
This PR moves the RAPID test bucket to us-central1-a and temporarily ignores takeoverAndAppendWithIncorrectChecksumFails, the only test that hit the quota there in a trial run. There are no other changes.