Repository navigation
test(spanner): fall back to local Python version for mockserver tests - #18861
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the noxfile.py in packages/google-cloud-spanner to dynamically resolve the default Python version for mock server tests. It introduces an import of the sys module and updates DEFAULT_MOCK_SERVER_TESTS_PYTHON_VERSION to use the MOCK_SERVER_TESTS_PYTHON_VERSION environment variable if set, fall back to '3.12' if python3.12 is available on the system, or otherwise default to the active Python interpreter's version. There are no review comments, and I have no feedback to provide.
Fall back to the local Python version when running mockserver tests to prevent CI failures due to new Python versions, or local build failures due to missing Python versions locally. The mockserver tests do not really care about which Python version is being used, as long as it is one that is supported by the Spanner client.
olavloite
force-pushed
the
spanner-fallback-python-version
branch
from
October 27, 2026 07:37
5409802 to
c2dee5e
Compare
sakthivelmanii
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fall back to the local Python version when running mockserver tests to prevent CI failures due to new Python versions, or local build failures due to missing Python versions locally. The mockserver tests do not really care about which Python version is being used, as long as it is one that is supported by the Spanner client.