[chalmerlowe]

Problem / Context

Stacked on #18866.

In packages/gapic-generator/tests/system/test_span_compliance.py, the "Client Timeout" scenario (F1.4, F1.9, F2.4, F2.8) previously called client.echo() with a simulated server-side DEADLINE_EXCEEDED status payload (EchoRequest(error=Status(code=DEADLINE_EXCEEDED))). Because the local Showcase server returned that simulated error response in under 1 millisecond, the test was exercising a server-returned 504 response rather than a genuine client-side deadline expiration before the server responds.

Solution

• test_span_compliance.py:
  • Updated run_echo_call in the "Client Timeout" scenario to call client.block() with a 2-second server response_delay (SERVER_BLOCK_DELAY_SECONDS = 2) and a 200ms client timeout (SHORT_CLIENT_TIMEOUT_SECONDS = 0.2), ensuring the client genuinely times out before receiving a response from the server.
• telemetry_requirements_matrix.csv:
  • Updated F1.4 (HTTP T4), F1.9 (gRPC T4), F2.4 (HTTP T3), and F2.8 (gRPC T3) to reflect the Echo/Block endpoint and genuine client-side timeout attributes (http.response.status_code = NOT SET and ReadTimeout on HTTP; DEADLINE_EXCEEDED on gRPC).

[gemini-code-assist]

Code Review

This pull request updates the "Client Timeout" test scenario in the span compliance tests to use the block RPC (which delays the response) instead of simulating a timeout via an error status on the echo RPC. This change affects both the telemetry requirements matrix and the test implementation in test_span_compliance.py. Feedback on the changes suggests importing and using google.protobuf.duration_pb2.Duration explicitly for the response_delay field in BlockRequest to ensure compatibility with pure protobuf clients, rather than relying on dictionary conversion.

[gemini-code-assist]

Import duration_pb2 from google.protobuf to allow explicit instantiation of the Duration message for the BlockRequest.

Suggested change

	import requests.exceptions
	import requests.exceptions
	from google.protobuf import duration_pb2

[gemini-code-assist]

Using a raw dictionary for the response_delay field in BlockRequest relies on proto-plus's automatic conversion. If the client is generated using pure protobuf (which is a supported configuration), this will raise a TypeError because pure protobuf constructors do not automatically convert dictionaries to submessages. Explicitly instantiating duration_pb2.Duration is more robust and compatible with both proto-plus and pure protobuf clients.

Suggested change

	BlockRequest(
	response_delay={"seconds": SERVER_BLOCK_DELAY_SECONDS},
	),
	BlockRequest(
	response_delay=duration_pb2.Duration(
	seconds=SERVER_BLOCK_DELAY_SECONDS
	),
	),