Skip to content

chore(bigtable): pin pytest<9 in system test dependencies - #18885

Closed
mutianf wants to merge 1 commit into
mainfrom
fix-bigtable-nox-pytest-pin
Closed

mutianf wants to merge 1 commit into
mainfrom
fix-bigtable-nox-pytest-pin

Conversation

@mutianf

@mutianf mutianf commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

pytest-asyncio==0.21.2 accesses FixtureManager._arg2fixturedefs, which was renamed to _arg2node2fixturedefs in pytest 9.0. Pin pytest<9 in SYSTEM_TEST_STANDARD_DEPENDENCIES so system test collection succeeds.
@mutianf
mutianf requested a review from a team as a code owner October 28, 2026 17:17

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the noxfile.py file in packages/google-cloud-bigtable to restrict the pytest dependency to versions less than 9 (pytest<9) for system tests. There are no review comments, and I have no feedback to provide.

@mutianf

mutianf commented Oct 28, 2026

Copy link
Copy Markdown
Contributor Author

Should be fixed in #18883 already.

@mutianf mutianf closed this Oct 28, 2026
@mutianf
mutianf deleted the fix-bigtable-nox-pytest-pin branch October 28, 2026 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant