Repository navigation
fix(bigquery): default query results polling timeout - #18887
Open
huong8373tt-beep wants to merge 1 commit into
Open
huong8373tt-beep wants to merge 1 commit into
huong8373tt-beep wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the default timeout behavior in _reload_query_results within the BigQuery query job module. Specifically, the default timeout parameter is changed from None to POLLING_DEFAULT_VALUE. When the timeout is set to this default, the method falls back to the transport timeout, and if that is not set, it now defaults to DEFAULT_GET_JOB_TIMEOUT instead of None. Unit tests have been added and updated to reflect these changes. There are no review comments, so I have no feedback to provide.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DEFAULT_GET_JOB_TIMEOUTto defaultjobs.getQueryResultspolling requests fromQueryJob.result()timeout=NonebehaviorNonetransport timeout selection, and update affected polling expectationsFixes #18857.
Testing
.venv\Scripts\python.exe -m pytest tests/unit/job/test_query.py -q(64 passed)black --check google\cloud\bigquery\job\query.py tests\unit\job\test_query.pygit diff --check.venv\Scripts\python.exe -m compileall -q google tests\unit\job\test_query.pyDisclosure
Slai Agent Runtime assisted with the investigation, implementation, and testing of this contribution. The account owner authorized the submitted changes and is responsible for the submission.