Repository navigation
feat: update API sources and regenerate - #18889
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces several updates across Google Cloud Python client libraries, including the addition of the ReplaceMessageCards API to google-apps-chat, the new SearchService to google-cloud-chronicle (replacing DataA2AService from geminidataanalytics), and new grounding settings to google-cloud-documentai. Two critical bugs were identified in the generated REST transports for both google-apps-chat and google-cloud-chronicle where debug logging attempts to serialize the raw HTTP response object instead of the parsed proto-plus message instance, which will lead to runtime exceptions when debug logging is enabled.
| response_payload = message.ReplaceMessageCardsResponse.to_json( | ||
| response | ||
| ) |
There was a problem hiding this comment.
In the REST transport response logging block, the code attempts to serialize the HTTP response object (response) using the proto-plus message's to_json method instead of the parsed proto-plus message instance (resp). This will raise an exception at runtime when debug logging is enabled, causing the payload to always be logged as None. It should be updated to serialize resp instead.
| response_payload = message.ReplaceMessageCardsResponse.to_json( | |
| response | |
| ) | |
| response_payload = message.ReplaceMessageCardsResponse.to_json( | |
| resp | |
| ) |
| response_payload = gcc_search.ListSearchedResultsResponse.to_json( | ||
| response | ||
| ) |
There was a problem hiding this comment.
In the REST transport response logging block, the code attempts to serialize the HTTP response object (response) using the proto-plus message's to_json method instead of the parsed proto-plus message instance (resp). This will raise an exception at runtime when debug logging is enabled, causing the payload to always be logged as None. It should be updated to serialize resp instead.
| response_payload = gcc_search.ListSearchedResultsResponse.to_json( | |
| response | |
| ) | |
| response_payload = gcc_search.ListSearchedResultsResponse.to_json( | |
| resp | |
| ) |
3157710 to
750aba6
Compare
Update googleapis API sources and regenerate all Python libraries (excluding
google-cloud-cesper #18888 andgoogle-cloud-chronicleper #18890).Debug Info
System Details
Commands Executed
go run github.com/googleapis/librarian/cmd/librarian@v0.50.0 update sources.googleapisgo run github.com/googleapis/librarian/cmd/librarian@v0.50.0 installgo run github.com/googleapis/librarian/cmd/librarian@v0.50.0 generate --allgit add .git commit -m "feat: update API sources and regenerate"Included googleapis CLs
google/chat/v1
google/cloud/ces/v1beta
google/cloud/chronicle/v1
google/cloud/documentai/v1beta3
google/cloud/geminidataanalytics/v1
google/cloud/geminidataanalytics/v1alpha
google/cloud/geminidataanalytics/v1beta
google/cloud/memorystore/v1
google/cloud/memorystore/v1beta
google/cloud/modelarmor/v1
google/cloud/oracledatabase/v1
google/cloud/redis/cluster/v1
google/cloud/redis/cluster/v1beta1
google/cloud/sql/v1
google/cloud/sql/v1beta4
google/cloud/video/transcoder/v1
google/shopping/merchant/quota/v1