Repository navigation
feat(google/cloud/designcenter/v1): add google-cloud-designcenter - #18894
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the new google-cloud-designcenter Python client library package, including its auto-generated GAPIC client code, configurations, and Sphinx documentation. A review comment suggests dynamically importing the package version in the Sphinx configuration (conf.py) instead of hardcoding it to an empty string to ensure the documentation displays the correct version.
| # See also: https://github.com/docascode/sphinx-docfx-yaml/issues/85 | ||
| sys.path.insert(0, os.path.abspath(".")) | ||
|
|
||
| __version__ = "" |
There was a problem hiding this comment.
The __version__ variable is currently hardcoded to an empty string "". This will cause the generated Sphinx documentation to display an empty version. Since the package version is defined in google/cloud/designcenter/gapic_version.py, we should import it dynamically to ensure the documentation always reflects the correct version.
| __version__ = "" | |
| from google.cloud.designcenter.gapic_version import __version__ |
…onfig dependencies
Onboard google/cloud/designcenter/v1 API (google-cloud-designcenter).
Internal tracking bug http://b/577038296
PiperOrigin-RevId: 1005520228
Debug Info
System Details
Commands Executed
python3 -m venv venv && source venv/bin/activatepip install --upgrade pipgo run github.com/googleapis/librarian/cmd/librarian@v0.50.0 installgo run github.com/googleapis/librarian/cmd/librarian@v0.50.0 add google/cloud/designcenter/v1go run github.com/googleapis/librarian/cmd/librarian@v0.50.0 generate -v google-cloud-designcentergo run github.com/googleapis/librarian/cmd/librarian@v0.50.0 tidygit add .git commit -m "feat(google/cloud/designcenter/v1): add google-cloud-designcenter"