Repository navigation
Conversation
Change-Id: I99ba8df327b6c168c15e51b3e09889687870db68
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-authored by @zigzag. Thanks for finding this fix and submitting PR #1734! This PR patches the changes so that our internal processes can be run.
Issue:
The two button variable names in
samples/control-custom-state/index.tswere swapped relative to their actual behavior.setCenterButtonwas bound tobtnCenterMap(the button that recenters the map) but only applies the stored center, so it doesn't "set" anything.resetCenterButtonwas bound tobtnSetCenter(the button that stores the current center) but is the one that actually stores it, so it doesn't "reset" anything.Changes made:
setCenterButtontocenterMapButton(bound tobtnCenterMap)resetCenterButtontosetCenterButton(bound tobtnSetCenter)Change-Id: I99ba8df327b6c168c15e51b3e09889687870db68