Repository navigation
Build the read-only schema with the code registry and schema directives - #898
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ectives toReadOnlySchema() repeated the builder calls of toSchema() and missed the code registry, so interfaces and unions had no type resolver, and the directives applied to the schema. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #896
Checklist
Description
SchemaObjects#toReadOnlySchema()failed on any schema with an interface or a union:It repeated the builder calls of
toSchema()without the mutation and subscription, and over timetoSchema()got the code registry (where the type resolvers live since graphql-java 13) and the directives applied to the schema, buttoReadOnlySchema()didn't. #894 already added the directive definitions, so a custom directive on a field works on master. The code registry and the schema directives were still missing.So both now start from one private
newSchema()builder, andtoSchema()only adds the mutation and subscription on top. That way the two can't drift again.Added
ReadOnlySchemaTest, which builds a read-only schema with an interface, a union, a field directive andextend schema @contact(...), queries every field and checks there's no mutation type. It failed with the error above before the fix.mvn clean verifypasses on graphql-java 26.1 and 25.1. Also checked through the public API: a schema with an interface and a union failed to build on master, and with this change returns theCatandDogvalues for both on graphql-java 26.1 and 25.1, withmutationTypenull.