[oryan-block]

Fixes #863
Fixes #865

Checklist

• Pull requests follows the contribution guide
• New or modified functionality is covered by tests

Description

Since #855 extensions are merged into the type they extend, and a repeat across the two was handled differently per kind. An enum value, interface field or union member declared twice kept the first one and logged a warning, so this builds Node with id: ID and only a log line says the extension's id was dropped:

interface Node { id: ID }
extend interface Node { id: String }

An object or input type that declared a field twice kept the last one, with a WARN since #920, and input objects listed the fields of their extensions before their own. graphql-java rejects the repeats and lists the type's fields first. These schemas built before #855 because the extension replaced the type, so they had to wait for 15.0.0.

Two commits, one per issue:

• Reject enum values, interface fields and union members that a type declares twice in 15.0.0 #863 turns warnRepeated into rejectRepeated, which throws a SchemaError, and drops the two distinctBy calls. The message names the type, the repeated item and where the repeat is: Type 'Node' declares field 'id' more than once at line 2, column 25. The location is left out when the definition has none.
• Make repeated fields and field order of object and input extensions match graphql-java in 15.0.0 #865 runs object fields and input object fields through the same rejectRepeated (the merge with master drops Warn about a field that an object or input type declares twice #920's warnRepeatedFields for it), and builds input fields from definition.withExtensions(typeExtensions), so the type's fields come first and then each extension's in order.

The check looks at the type and its extensions together, so a repeat inside one definition fails too (enum Color { RED RED }, type Query { a: String a: Int }). For enums, interfaces and unions the warning already covered that. For objects and input objects #920 added the warning, and throwing is what graphql-java does (has declared a field with a non unique name).

On graphql-java 26.1 and 25.1 I ran the same repeats through SchemaGenerator to see what to match. It rejects a repeated input field too, in SchemaTypeChecker before it generates anything, so the hasField check in buildInputObjectType that keeps the first one never gets a repeat. One difference: 25.1 doesn't flag a union member repeated between the type and an extension, 26.1 does. We reject it on both.

In TypeExtensionTest the test for extensions without a type no longer repeats anything, and there's a test for the errors (enum, interface, union, object, input, plus repeats between two extensions and inside one definition) and one for the input field order. Two of #920's warning cases became error cases here, a repeat in an input reached through another input and one in a definition without a source location. Filter in the test got limit and offset so the order test can query it, and inner for the nested input.

Verified with mvn clean verify on graphql-java 26.1 and with -Dgraphql-java.version=25.1, 412 tests each, no failures. After merging master (which dropped graphql-java 25 in #919 and added #920), mvn clean verify on 26.1 runs 415 tests, no failures. verify-tools on master before #920 and on this branch before the merge:

• type-extensions: master exits 0 with Type 'Node' declares field 'id' more than once, only the first one is kept., the branch exits 2 with Type 'Node' declares field 'id' more than once at line 19, column 5 in scenarios/type-extensions/schema.graphqls.
• a Query with greeting in the type and again in extend type Query: master builds with the extension's description, the branch exits 2 with Type 'Query' declares field 'greeting' more than once at line 7, column 5.
• input Filter with extensions before and after it: getFieldDefinitions() gives [limit, offset, term] on master and [term, limit, offset] on the branch.
• type-extensions-sealed builds the same on both.

Release note: a type and its extensions, or a single object or input definition, can't declare the same enum value, interface field, union member, object field or input field twice anymore. Before, enums, interfaces and unions kept the first one and objects and input objects kept the last one, each with a WARN. Now the build throws a SchemaError like Type 'Color' declares value 'RED' more than once at line 6, column 5. Remove the repeat from the type or the extension, since an extension only adds what the type doesn't have. Input objects also list the fields of the type first, then those of each extension in order, where the extensions' fields used to come first, so code that reads GraphQLInputObjectType.getFieldDefinitions() by position sees the new order.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud