Repository navigation
Declare central.sonatype.com as a repository origin - #929
Merged
Merged
Conversation
setup-java v6.1.0 writes repositoryOrigins into settings.xml, so the snapshot deploy no longer needs maven.repository.credentialScope=id to send credentials under Maven 3.10. The release deploy gets the same origin, which removes its credentials warning.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #841
Checklist
Description
setup-javav6.1.0 addedmvn-server-repository-origins, and@v6already points to it. This declareshttps://central.sonatype.comas an origin of thecentralserver and drops the-Dmaven.repository.credentialScope=idworkaround from #840. Maven 3.10 sends the credentials again, and its origin scoping stays on.The release workflow gets the same origin. Its deploy wasn't broken, because
central-publishing-maven-pluginuploads the bundle with its own client. It did logNot using credentials of server 'central' for repository https://central.sonatype.com/repository/maven-snapshots/on every run, the latest being this one.I checked this locally with Maven 3.10.0, a throwaway snapshot project and dummy credentials. Without
<repositoryOrigins>, Maven logs the warning and drops the credentials. With the blocksetup-javawrites, there's no warning and the credentials are sent. Both runs get a 401 because the credentials are dummies. The real check is the snapshot publish after this merges.