Repository navigation
Fix: Include slave_id when moving tasks - #1390
Merged
Merged
Conversation
Send an empty slave_id for the master by default and reject explicit None instead of omitting the required attribute. Cover default, master, slave, and invalid values in request and client tests. Commit generated using the `pi` coding agent harness (model: openai-codex/gpt-6-sol).
greenbonebot
enabled auto-merge (rebase)
October 8, 2026 12:56
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
Conventional Commits Report
🚀 Conventional commits found. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1390 +/- ##
=======================================
Coverage 98.40% 98.40%
=======================================
Files 106 106
Lines 6886 6888 +2
Branches 1244 1244
=======================================
+ Hits 6776 6778 +2
Misses 77 77
Partials 33 33 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Match Ruff formatting for the GMPv224 and GMPNext move_task methods. Commit generated using the `pi` coding agent harness (model: openai-codex/gpt-6-sol).
bjoernricks
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Default
move_task()to the master scanner by sendingslave_id=""in GMPv224-derived clients (including GMPv227) and GMPNext. Reject an explicitNonerather than generating an invalid request. Update docstrings and tests for default, empty, nonempty, andNonevalues.Why
GMP requires a
slave_idattribute formove_task; omitting it caused gvmd to return 400 instead of moving the task to the master scanner.References
Checklist