Repository navigation
Add optional Mute characteristic to Doorbell service - #211
Merged
Merged
Conversation
Mute is an optional characteristic of the Doorbell service. The 2.0.1 changelog lists it for the Doorbell service, but it was only wired into DoorService. DoorService is left unchanged to stay compatible.
ccutrer
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
DoorbellServicenow adds the optional Mute characteristic (11A) when the accessory implementsAccessoryWithMute, like it already does for Name, Brightness and Volume. It also gets anaddOptionalCharacteristic(MuteCharacteristic)overload.Why
Mute is an optional characteristic of the Doorbell service (see the HAP-NodeJS
Doorbelldefinition). The 2.0.1 changelog says "Add Mute characteristic to Doorbell service", but commit 40e0338 wired Mute intoDoorServiceinstead, andDoorbellServicenever got it.Compatibility
Purely additive. Doorbells that don't implement
AccessoryWithMuteare unchanged.DoorServicekeeps its Mute support: removing it would drop a public method, and nothing requires the change.Testing
mvn -B packageon JDK 11: all 23 tests pass. The newDoorbellServiceTestcovers:AccessoryWithMute, the Mute characteristic is added, reports the accessory's state and forwards writes tosetMuteNote: like #207, #209 and #210, this adds a
# HAP-Java 2.0.10section to CHANGES.md.