Repository navigation
fix(shell): search boxes never drop keystrokes; E2E CI budget + race fixes - #227
Merged
Merged
Conversation
The dev-auth E2E failed on CI after #224 merged (the Ctrl+K → Model keys step): opening Settings in a new window and rendering the page can exceed Playwright's 5 s expect default on a shared GitHub runner, while it passes every time on a dev box. Set the default once in both fixtures (GITHUB_ACTIONS → 15 s) instead of sprinkling per-assertion timeouts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018WAdQ7Rm24xss5QDSvXtJB
CI showed the real cause of the red E2E: the Activities search received "add key" as "ay". The input rendered value="@_query" from server state on every keystroke, so a slow round-trip re-rendered a stale value over the keys typed meanwhile — real users on a laggy link lose keys the same way. The Activities search and the Settings rail search are now uncontrolled (no server-written value); clearing / reopening swaps in a fresh element via @key. A source guard test fails the build if a text input with @oninput renders value="@…" again. Two timing-only E2E races fixed alongside: Ctrl+K in Workflow waits for the builder's key handler (registered after first render), and the motion test waits for the restored toggle state after a reload before clicking. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018WAdQ7Rm24xss5QDSvXtJB
hoangsnowy
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI dev-auth E2E failed after #224 (Ctrl+K → Model keys on a slow runner; passes locally every run). Default Playwright expect timeout set once in both fixtures: 15 s when GITHUB_ACTIONS=true, 5 s locally.
Test plan
🤖 Generated with Claude Code
https://claude.ai/code/session_018WAdQ7Rm24xss5QDSvXtJB