Repository navigation
tikkie: add 2 doc-sourced samples (REFUND, BUNDLE) - #63
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the two Tikkie notification types missing upstream:
REFUNDandBUNDLE. This is the additive delta from hookdeck/webhook-registrysamples-doc/after hookdeck/webhook-registry#87 rebuilt the tikkie row from ABN AMRO's OpenAPI spec.What's added
providers/tikkie/latest/REFUND.jsonRefundNotificationexample on thePaymentRequestNotificationcallback ofPOST /paymentrequestssubscriptionproviders/tikkie/latest/BUNDLE.jsonBundledPayoutNotificationexample on theTransactionsNotificationcallback ofPOST /transactionssubscriptionBoth come verbatim from the spec the reference page renders (TikkieAPI_v2.3.yaml). They are complete bodies that carry every field the schema requires, and each file has a
sourceblock withtype: vendor-documentation. With these, upstream covers the spec's wholenotificationTypeenum (PAYMENT,REFUND,BUNDLE).Headers:
content-type: application/jsononly. The discriminator (notificationType) is in the body, and Tikkie notifications are unsigned, so there is no signature header to synthesize.Checklist (SAMPLE-PUBLISHING.md)
scripts/tikkie/harness exists, and neither topic is captured upstream.latest/, matching the existing entry. Notifications carry no version; the/v2in the API path versions the REST API, not the notification body.topic_identifier: unchanged (notificationType), and it matches the registry'sdiscriminator_path_lookup.PAYMENT.json(body identical to the spec's example) andindex.jsonare untouched.provenance.latest.sourced_onstays2026-07-29, the oldest date in the version (rule 8)./api-products/tikkie/reference-documentation) still resolves.yarn compilepasses:tikkie/latest.jsonnow has 3 topics.yarn testpasses 14/14.verify.py: FAIL (0) at 6bec6bb.Volume was checked too and needs no change: upstream
providers/volume/is byte-identical to the registry'ssamples-doc/.🤖 Generated with Claude Code