Skip to content

tikkie: add 2 doc-sourced samples (REFUND, BUNDLE) - #63

Merged
garethx merged 1 commit into
mainfrom
samples-tikkie
Oct 8, 2026
Merged

garethx merged 1 commit into
mainfrom
samples-tikkie

Conversation

@garethx

@garethx garethx commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Adds the two Tikkie notification types missing upstream: REFUND and BUNDLE. This is the additive delta from hookdeck/webhook-registry samples-doc/ after hookdeck/webhook-registry#87 rebuilt the tikkie row from ABN AMRO's OpenAPI spec.

What's added

File Source
providers/tikkie/latest/REFUND.json RefundNotification example on the PaymentRequestNotification callback of POST /paymentrequestssubscription
providers/tikkie/latest/BUNDLE.json BundledPayoutNotification example on the TransactionsNotification callback of POST /transactionssubscription

Both come verbatim from the spec the reference page renders (TikkieAPI_v2.3.yaml). They are complete bodies that carry every field the schema requires, and each file has a source block with type: vendor-documentation. With these, upstream covers the spec's whole notificationType enum (PAYMENT, REFUND, BUNDLE).

Headers: content-type: application/json only. The discriminator (notificationType) is in the body, and Tikkie notifications are unsigned, so there is no signature header to synthesize.

Checklist (SAMPLE-PUBLISHING.md)

  • Capture vs doc: no scripts/tikkie/ harness exists, and neither topic is captured upstream.
  • Version: latest/, matching the existing entry. Notifications carry no version; the /v2 in the API path versions the REST API, not the notification body.
  • topic_identifier: unchanged (notificationType), and it matches the registry's discriminator_path_lookup.
  • Existing files changed: zero. PAYMENT.json (body identical to the spec's example) and index.json are untouched.
    • provenance.latest.sourced_on stays 2026-07-29, the oldest date in the version (rule 8).
    • PAYMENT's recorded URL (/api-products/tikkie/reference-documentation) still resolves.
  • yarn compile passes: tikkie/latest.json now has 3 topics. yarn test passes 14/14.
  • Registry verify.py: FAIL (0) at 6bec6bb.

Volume was checked too and needs no change: upstream providers/volume/ is byte-identical to the registry's samples-doc/.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@vercel

vercel Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
webhook-samples Ready Ready Preview Oct 8, 2026 3:12pm UTC

Request Review

@garethx
garethx merged commit 466ce90 into main Oct 8, 2026
3 checks passed
@garethx
garethx deleted the samples-tikkie branch October 8, 2026 15:17

This branch was successfully deployed

1 active deployment
Preview — 1ba81e6b Deployed Oct 8, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant