Skip to content

Remove output_type="latent" from modular decoders - #15078

Open
dhvani7014 wants to merge 1 commit into
huggingface:mainfrom
dhvani7014:fix-15071-latent
Open

dhvani7014 wants to merge 1 commit into
huggingface:mainfrom
dhvani7014:fix-15071-latent

Conversation

@dhvani7014

Copy link
Copy Markdown

What does this PR do?

Fixes #15071

Removes the output_type == "latent" branches from the modular decode blocks for flux, sd3, sdxl, cosmos and echo. Latents are available via output="latents" instead. ltx2 is left for #14612. Will rebase after #14737 merges.

Self-review notes

  • Removed the output_type="latent" branches from the flux, sd3, sdxl, cosmos and echo modular decoders.
  • Passing output_type="latent" now raises a ValueError pointing to output="latents", same as minimax_h3. Happy to switch to a deprecation warning if you prefer.
  • Dropped the unused output_type input from EchoAudioDecoderStep.
  • Tests that used "latent" now read latents/audio_latents from the output or use output_type="pt". The echo audio stats test checks _denormalize_audio_latents directly, since the decoder can no longer return latents.
  • Updated the echo docs line that described the latent output.
  • Ran make style, make fix-copies, and pytest tests/modular_pipelines/echo tests/modular_pipelines/cosmos: 93 passed, 25 skipped.

Before submitting

Who can review?

@yiyixuxu

@github-actions github-actions Bot added documentation Improvements or additions to documentation tests modular-pipelines fixes-issue size/L PR with diff > 200 LOC labels Oct 19, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation fixes-issue modular-pipelines size/L PR with diff > 200 LOC tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Follow-up to #14737: drop output_type="latent" from modular decode blocks

1 participant