Repository navigation
Conversation
see #4071. this commit addresses the `let_unit_value` clippy lint. only two sites are affected, relating to tracing spans. Signed-off-by: katelyn martin <git@katelyn.world>
cratelyn
marked this pull request as ready for review
October 10, 2026 04:22
dswij
reviewed
Oct 11, 2026
| } | ||
|
|
||
| let _entered = trace_span!("parse_headers"); | ||
| trace_span!("parse_headers"); |
Member
There was a problem hiding this comment.
trace_span returns a guard when tracing features is enabled. So the binding here actually serves a purpose.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #4071.
see https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value.
this commit addresses the
let_unit_valueclippy lint. only two sitesare affected, relating to tracing spans.