Repository navigation
feat(corpus): wire all 17 adapters into the CLI dispatcher - #418
Merged
Merged
Conversation
`echidna corpus ingest --adapter` only dispatched agda, coq, lean and idris2, although src/rust/corpus/ ships 17 ingest adapters. Add the remaining 13 (acl2_books, dafny, fstar, hol4, hol_light, isabelle, metamath, minif2f, mizar, proofnet, smtlib, tptp, why3) to the match, list all 17 in the unknown-adapter error and the --adapter help text. Adds tests/corpus_cli_dispatch.rs: every advertised name must reach its adapter (no "Unknown corpus adapter" fallthrough), and an unknown name must exit non-zero listing the supported set. Co-authored-by: arena-agent <297053741+arena-agent@users.noreply.github.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 3 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
hyperpolymath
enabled auto-merge (squash)
October 9, 2026 19:11
hyperpolymath
disabled auto-merge
October 9, 2026 19:12
hyperpolymath
pushed a commit
that referenced
this pull request
Oct 9, 2026
rust-ci's `cargo fmt --check` failed on #418 (main 7fd369d). Two layout spots did not match rustfmt output: - the SUPPORTED array: rustfmt packs literal arrays into mixed rows; use a single whitespace-separated string constant instead, iterated with split_whitespace(); - an assert! whose argument list exceeds fn_call_width (60): split it vertically. No behaviour change. Co-authored-by: arena-agent <297053741+arena-agent@users.noreply.github.com>
hyperpolymath
added a commit
that referenced
this pull request
Oct 9, 2026
…#418) (#425) ## Summary Follow-up to #418 (merged). Its \`Rust CI\` run on \`main\` (7fd369d) failed at **Cargo fmt**; Cargo check passed, clippy was skipped. This PR changes only \`tests/corpus_cli_dispatch.rs\` layout to match rustfmt: - \`SUPPORTED\` becomes a whitespace-separated string constant (rustfmt packs literal arrays into mixed rows) - one \`assert!\` whose arguments exceed \`fn_call_width\` is split vertically No behaviour change. ## Notes - Job logs were unavailable from the sandbox (blob download EOF), so the fmt diagnosis comes from the per-step result (\`Cargo fmt\` = failure, \`Cargo check\` = success) plus a manual check against rustfmt rules. rustfmt itself could not be run here (crates.io and static.rust-lang.org are not reachable). - Clippy and the test job have not run on this code yet; they are gated behind fmt in the same job, so CI is the next check. Co-authored-by: arena-agent <297053741+arena-agent@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
`echidna corpus ingest --adapter` only dispatched `agda, coq, lean, idris2`, although `src/rust/corpus/` ships 17 ingest adapters. This wires the remaining 13 into the match in `src/rust/main.rs`:
acl2_books, dafny, fstar, hol4, hol_light, isabelle, metamath, minif2f, mizar, proofnet, smtlib, tptp, why3
The unknown-adapter error and the `--adapter` help text now list all 17.
Tests
New `tests/corpus_cli_dispatch.rs`:
Notes