Repository navigation
Fix memory scheduling, Telegram topics, and context diagnostics - #263
Merged
Merged
Conversation
Owner
Author
|
The size warning is acknowledged. Most affected files propagate the same optional Telegram topic field through existing call sites. Behavioral changes and regression tests are concentrated in memory scheduling/storage, Telegram delivery, and context capture. This PR delivers the three requested runtime fixes together; the full workspace gate and PostgreSQL memory regressions passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Memory backfill can delay fresh windows for hours, stop admitting work at 5,000 queued runs, and leave older history waiting for the next nightly scan. Telegram direct-message topic IDs are also lost across dialog delivery, while oversized LLM requests lose useful context diagnostics when raw-body capture is omitted.
Validation:
tools/rust-fast-gate.shpassed formatting, Clippy across all workspace targets/features, and workspace tests (2,592 passed, 10 ignored).cargo test --locked -p openplotva-storage live_memory_ -- --test-threads=1passed all five tests against local PostgreSQL 17 with pgvector. The regression admits 5,001 historical windows, then prioritizes a newly admitted fresh window and verifies repeated scans do not duplicate work. Telegram tests cover 64-bit topic IDs, dispatcher propagation, multipart fields, persistence/replay, and deduplication.Operational changes:
MEMORY_MAX_QUEUED_RUNSis obsolete and ignored; admin/telemetry limit fields return null. The full retained history is scanned hourly, but previously enqueued windows are not extracted again. Retention, per-run input limits, retries, and inference concurrency remain in force. No database migration is required. Production verification will check the deployed revision, queue progress, and new diagnostic metadata.