Repository navigation
Fix settings access for groups with a non-admin bot - #264
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening group settings fails with HTTP 500 when a non-admin bot receives
CHAT_ADMIN_REQUIREDfrom TelegramgetChatMember, even for an administrator who has permission to manage settings.On this specific Telegram 400 response, resolve the caller from a fresh
getChatAdministratorsresponse. Both the Settings WebApp and the group settings command use this adapter. Existing owner/admin permission checks remain in place. A missing caller, failed fallback, or unrelated Telegram error does not grant access.Validation:
cargo test --locked -p openplotva-app: 1,411 passed, 7 ignored, 0 failed.cargo clippy --locked --workspace --all-targets -- -D warnings: passed.cargo fmt --all -- --checkandgit diff --check: passed.