feat(ci): test and publish on Node 24 LTS - #248
Merged
Conversation
Coverage: 94.75% (was 94.75%)
Contributor
There was a problem hiding this comment.
Pull request overview
Updates GitHub Actions workflows to validate the project on both the declared minimum Node.js version (20) and the maintained LTS runtime (24), while ensuring publishing continues to run on Node 24 with the existing trusted-publishing npm pin preserved.
Changes:
- Add a CI matrix to run lint/build/tests on Node 20 and Node 24 (with independent results).
- Update both npm publishing jobs to run on Node 24.
- Adjust workflow commentary to keep the “exact npm pin” rationale accurate regardless of runner-bundled npm versions.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/ci.yml | Adds a Node 20/24 matrix (fail-fast disabled) and uses the matrix version in setup-node. |
| .github/workflows/npm-publish.yml | Switches publish jobs to Node 24 and updates trusted-publishing pin commentary to be runner-version-agnostic. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Up to standards ✅🟢 Issues
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reimplements the useful maintained-runtime scope from #175 against current main; the contributor branch was not modified.
Testing