Repository navigation
Fixed code review issue in rotate/funnel_shift offsets - #46
Merged
Merged
Conversation
A code review found a corner case in rotates and shifts that led to suspicious behaviour. This issue wasn't present in the implementation described in the standards paper that introduced funnel shifts (P4010). xvec has been modified to match the example implementation of the standards proposal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A code review found a corner case in rotates and shifts that led to suspicious behaviour. This issue wasn't present in the implementation described in the standards paper that introduced funnel shifts (P4010). xvec has been modified to match the example implementation of the standards proposal.