Repository navigation
Fix Windows wepoll initialization failure detection - #909
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When wepoll
epoll_create()fails on Windows, it returnsNULL.iowatcher_init()currently checksepfd < 0, so it publishes a non-null watcher context containing a null native handle and reports successful initialization. A later registration fails, and subsequent additions reuse that invalid context instead of retrying creation.Check
epfd == NULLunderOS_WIN, retaining the existing< 0check on Linux. A failed creation now returns before allocating or publishing the context, so a later registration can retry. This follows the bundled wepoll contract.The new Windows
epoll_init_testinjects one creation failure, then uses real wepoll ports to check successful retry, idempotent initialization, native handle validity and closure, cleanup, and ordinary recreation. Its checks remain active in Release builds. CMake includes the target whenBUILD_UNITTEST=ONandWITH_WEPOLL=ONon Windows.hio_add()already reports registration failure through the existingepoll_ctl()check. This patch fixes initialization state and retry; it does not change that public return convention or repeat the Linux error-propagation changes from PR #837.