Repository navigation
test: ensure PeriodicMetricReader waits for timed out export completion - #29
Open
Rajkaran-122 wants to merge 3 commits into
Open
Rajkaran-122 wants to merge 3 commits into
Rajkaran-122 wants to merge 3 commits into
Conversation
Signed-off-by: Rajkaran Yadav <yadavrajkaran854@gmail.com>
Author
|
@jack-berg sir PTAL . |
jack-berg
reviewed
Sep 24, 2026
- Fix tick coalescing regression by adding isTick field to Signal and only clearing tickPending for TICK signals - Rename exporterTimeout_waitsForCompletionBeforeNextBatch to exporterTimeout_batchesCalledInOrder and use deterministic assertions - Remove trivial builder timeout tests that only checked isNotNull() - Add tickCoalescing_withSlowExporter regression test
Author
|
@jack-berg sir PTAL. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add regression test from closed PR open-telemetry#8684 to verify that PeriodicMetricReader waits for timed out export completion before starting the next export.
This test ensures that when an export times out, the dedicated worker thread waits for the actual exporter operation to complete before processing the next batch, preventing concurrent exporter invocations which would violate the spec.
Adapted from the open-telemetry#8684 implementation to work with the current open-telemetry#8827 dedicated worker thread architecture.