Repository navigation
Conversation
The flag only reached the dist's build.py, which compiles the app's --private sources. The standard library, the extension modules and site-packages are byte-compiled earlier, by the python3 recipe while the distribution is assembled, and that call hardcoded -OO. Asking for unoptimized bytecode therefore still stripped docstrings and asserts from everything except the app's own files. Parse the flag in the toolchain as well and let the recipe consult ctx.optimize_python. It goes on the generic parser, next to the other options that control how a distribution is built, because the recipe runs under `create` too, not only under the packaging commands. For those it is also kept in unknown_args, so the bootstrap's build.py keeps receiving it the way --private and --with-debug-symbols do.
|
coverage: 63.302% (+0.02%) from 63.278% — f321x:202610_python3_honour_no_optimize into kivy:develop |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The flag only reached the dist's build.py, which compiles the app's --private sources. The standard library, the extension modules and site-packages are byte-compiled earlier, by the python3 recipe while the distribution is assembled, and that call hardcoded -OO. Asking for unoptimized bytecode therefore still stripped docstrings and asserts from everything except the app's own files.
Parse the flag in the toolchain as well and keep it in unknown_args so build.py still receives it, then let the recipe consult ctx.optimize_python. This follows --private and --with-debug-symbols, which are also build.py arguments that are needed before the distribution is assembled.
This is how the spesmilo fork currently patched this:
spesmilo@ecd5516
Related
#1221