Repository navigation
Conversation
✅ Deploy Preview for knative ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
|
/assign @evankanderson this is ready for review. Take a look at the preview. I added a temporary commit so it will do a full build showing the dropdowns in the netlify preview. I'll want to remove prior to merging. |
evankanderson
left a comment
There was a problem hiding this comment.
This is much better than what I did, thank you!
| [context.deploy-preview.environment] | ||
| BUILD_VERSIONS="no" | ||
|
|
||
| # TEMP: exercise the version selector in PR #6743; remove before merging. |
There was a problem hiding this comment.
Does this need to be removed at this point?
There was a problem hiding this comment.
I'd keep it because of netlify getting rate limited by github breaks our deploy builds
|
/hold |
cc518c9 to
39adb3e
Compare
|
/hold cancel I removed the TEMP commit now |
Replace the vendored Material JavaScript bundle used for Knative's directory-based version selector with upstream Material assets and a small hook/template implementation.
This is a focused follow-up to #6722. Its scope is limited to:
No multi-version local-preview preparation, hot-reload tooling, or dependency-aware incremental builds are included. Those remain on the separate development branch.
Proposed Changes
directoryprovider, and inline rewriting of Material's__configJSON. Inherit the installed theme's normal JavaScript and asset configuration.versions.jsonmanifest and rendered page/anchor data using a MkDocs hook.(Pre-release)even in single-version deploy previews.Validation
./hack/mkdocs.sh build --strictagainst current main.Full multi-release assembly and registry publishing were not exercised for this PR.