Repository navigation
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for knative ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Combined WIP review PR for the retained code-sample updates, documentation cleanup, consolidations, and directory-scoped deployment CI. Changes are grouped by component into focused commits to make the large diff easier to review; dependency lockfiles account for a substantial part of it.
Sample updates
Real deployment CI
Add one path-scoped GitHub Actions matrix with 39 jobs covering 40 demonstrations. It builds actual sample artifacts, provisions a disposable kind/Knative environment, waits for live workload readiness, asserts documented HTTP/event/protocol behavior, preserves failure diagnostics, and cleans up owned resources.
Only changed sample directories and explicitly declared shared-source dependents select deployment jobs. Harness-only edits validate the harness without deploying unrelated samples. Full sweeps are explicit. Fork PR jobs use read-only permissions and no real service credentials or
pull_request_target.The first run of this PR is expected to select all retained sample jobs because all their recipes are introduced here. Later changes should select only affected jobs. Hosted runs may require normal repository approval for fork workflows.
Review guide
No workstation audit reports, private kubeconfigs, or absolute audit-path dependencies are included. Original owner worktrees and detailed local evidence are preserved outside this branch.
Validation
go test -mod=vendor ./test/...passed in Docker, including canonical-source-link regressions.git diff --checkpassed.Local validation used Docker Desktop Linux/arm64, with emulation where needed. No GitHub-hosted/amd64 sweep or full website build is claimed yet. GitHub/GitLab APIs, Slack webhooks and observation endpoints are explicit local fixtures with dummy credentials; actual applications, adapters, controllers and routing paths are exercised, not real SaaS permissions/public callbacks.
Separate removal PRs
The previously requested removals remain separate and are not folded into this PR:
#6725 (KafkaBinding), #6726 (Deno), #6727 (BentoML), #6728 (Spark Java), #6729 (Scala/Akka), and #6747 (Go-wrapped R).
The CI registry records those retirement exclusions. The duplicate Go receiver and old Parallel layout are removed here as part of their requested consolidations.