Skip to content

Add Psalm taint analysis annotations #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
danog wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add Psalm taint analysis annotations #295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e157160
Add Psalm taint analysis annotations
danog Oct 23, 2026
575199a
Add file sinks to findLoad(), Source::newFromFile() and Target::newTo…
danog Oct 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/Image.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -692,6 +692,8 @@ private function callEnum(
* @param string $filename The file to test.
*
* @return string|null The name of the load operation, or null.
*
* @psalm-taint-sink file $filename
*/
public static function findLoad(string $filename): ?string
{
Expand All @@ -711,6 +713,8 @@ public static function findLoad(string $filename): ?string
* @throws Exception
*
* @return Image A new Image.
*
* @psalm-taint-sink file $name
*/
public static function newFromFile(
string $name,
Expand Down Expand Up @@ -955,6 +959,8 @@ public static function newFromSource(Source $source, string $string_options = ''
* @throws Exception
*
* @return void
*
* @psalm-taint-sink file $name
*/
public function writeToFile(string $name, array $options = []): void
{
Expand Down
2 changes: 2 additions & 0 deletions src/Source.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@ public static function newFromDescriptor(int $descriptor): self
*
* You can pass this source to (for example) @see Image::newFromSource()
* @throws Exception
*
* @psalm-taint-sink file $filename
*/
public static function newFromFile(string $filename): self
{
Expand Down
2 changes: 2 additions & 0 deletions src/Target.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ public static function newToDescriptor(int $descriptor): self
*
* You can pass this target to (for example) @see Image::writeToTarget()
* @throws Exception
*
* @psalm-taint-sink file $filename
*/
public static function newToFile(string $filename): self
{
Expand Down