Skip to content

LCORE-4827: Use new model in sources - #2964

Merged
tisnik merged 1 commit into
lightspeed-core:mainfrom
tisnik:lcore-4827-use-new-model
Oct 19, 2026
Merged

tisnik merged 1 commit into
lightspeed-core:mainfrom
tisnik:lcore-4827-use-new-model

Conversation

@tisnik

@tisnik tisnik commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Description

LCORE-4827: Use new model in sources

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library [pyproject.toml + uv.lock]
  • Bump-up dependent library [requirements.*.txt for Konflux]
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement
  • Benchmarks improvement

Tools used to create PR

  • Assisted-by: N/A
  • Generated by: N/A

Related Tickets & Documents

  • Related Issue #LCORE-4827

Summary by CodeRabbit

  • Documentation
    • Updated API, configuration, conversation, and error examples to reference gpt-5.6-luna.
    • Updated the streaming response example to reference gpt-4o-mini.

@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: lightspeed-core/lightspeed-stack/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: a3f4e910-4f32-43cc-a9b6-6ce020c460e3
📥 Commits

Reviewing files that changed from the base of the PR and between 952400e and b5a3ad6.

📒 Files selected for processing: 11
  • docs/devel_doc/openapi.json
  • docs/models/successful_responses.json
  • src/models/api/requests/responses_openai.py
  • src/models/api/responses/error/content_too_large.py
  • src/models/api/responses/error/not_found.py
  • src/models/api/responses/successful/catalog.py
  • src/models/api/responses/successful/conversations.py
  • src/models/common/conversation.py
  • src/models/compaction.py
  • src/models/config.py
  • src/pydantic_ai_lightspeed/capabilities/question_validity/_capability.py

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout: 21
  • GitHub Check: Pyright
  • GitHub Check: list_outdated_dependencies
  • GitHub Check: unit_tests (3.13)
  • GitHub Check: Pylinter
  • GitHub Check: shellcheck
  • GitHub Check: unit_tests (3.12)
  • GitHub Check: Red Hat Konflux / lightspeed-stack-0-8-e2e-tests / lightspeed-stack-0-8
  • GitHub Check: unit_tests (3.14)
  • GitHub Check: spectral
  • GitHub Check: build-pr
  • GitHub Check: mypy
  • GitHub Check: integration_tests (3.13)
  • GitHub Check: pydocstyle
  • GitHub Check: integration_tests (3.14)
  • GitHub Check: black
  • GitHub Check: radon
  • GitHub Check: integration_tests (3.12)
  • GitHub Check: Red Hat Konflux / lightspeed-core-0-8-enterprise-contract / lightspeed-stack-0-8
  • GitHub Check: Red Hat Konflux / rag-content-0-8-e2e-tests / lightspeed-stack-0-8
  • GitHub Check: Konflux kflux-prd-rh02 / lightspeed-stack-0-8-on-pull-request
  • GitHub Check: authorize / Check repository owner or member
🧰 Additional context used
🪛 Checkov (3.3.20)
docs/models/successful_responses.json

[high] 1-7995: Ensure that the global security field has rules defined

(CKV_OPENAPI_4)

docs/devel_doc/openapi.json

[high] 1-24658: Ensure that the global security field has rules defined

(CKV_OPENAPI_4)

[high] 1-24658: Ensure that security operations is not empty.

(CKV_OPENAPI_5)

🔇 Additional comments: 11
src/models/api/requests/responses_openai.py: 1

97-97: LGTM!

src/models/api/responses/error/content_too_large.py: 1

27-27: LGTM!

src/models/api/responses/error/not_found.py: 1

39-39: LGTM!

src/models/api/responses/successful/catalog.py: 1

130-130: LGTM!

src/models/api/responses/successful/conversations.py: 1

48-48: LGTM!

Also applies to: 70-70

src/models/common/conversation.py: 1

159-159: LGTM!

src/models/compaction.py: 1

40-40: LGTM!

src/models/config.py: 1

2056-2056: LGTM!

src/pydantic_ai_lightspeed/capabilities/question_validity/_capability.py: 1

66-66: LGTM!

docs/models/successful_responses.json: 1

6024-6024: LGTM!

docs/devel_doc/openapi.json: 1

1442-1442: LGTM!

Also applies to: 6113-6113, 6133-6133, 6490-6490, 6510-6510, 8539-8539, 9467-9467, 10365-10365, 10413-10413, 10735-10735, 10755-10755, 14106-14106, 14137-14137, 14187-14187, 15269-15269, 16319-16319, 18979-18979, 20920-20920, 22481-22481

Walkthrough

The pull request updates example model identifiers across API models and OpenAPI documentation. Most examples change from gpt-4o-mini to gpt-5.6-luna. The Responses SSE example changes from openai/gpt-5.6-luna to openai/gpt-4o-mini. No runtime behavior or schema signatures change.

Changes

Model example updates

Layer / File(s) Summary
Update model examples
src/models/api/*, src/models/common/conversation.py, src/models/compaction.py, src/models/config.py, src/pydantic_ai_lightspeed/capabilities/question_validity/_capability.py, docs/devel_doc/openapi.json, docs/models/successful_responses.json
Examples use gpt-5.6-luna across requests, responses, conversation models, configuration, shields, and OpenAPI documentation. The Responses SSE example uses openai/gpt-4o-mini in its created and completed events.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Suggested reviewers: asimurka

Merge Risk: ⚪ Minimal · up to b5a3a

The PR changes examples rather than runtime behavior, and the Responses example uses the catalog’s expected identifier format. No concrete merge-blocking issue is established.

Pre-merge checks: Passed 7
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly summarizes the main change: replacing the example model with a new model across source files and documentation.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 9…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Performance And Algorithmic Complexity Passed PASSED. The pull request changes 30 model-name strings across OpenAPI JSON, response examples, Pydantic examples, descriptions, and a docstring. The Python change in QuestionValidity is inside an ex…
Security And Secret Handling Passed PASSED. The PR changes only model names in documentation, schema examples, error examples, and a docstring code example. The diff adds no secrets, tokens, credentials, endpoint handlers, authorization…
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 9 files. (2 skipped: 2 unsupported.)

Full details: Performance And Algorithmic Complexity

Explanation

PASSED. The pull request changes 30 model-name strings across OpenAPI JSON, response examples, Pydantic examples, descriptions, and a docstring. The Python change in QuestionValidity is inside an example block. No loops, list operations, API calls, parsing, caches, buffers, or endpoint changes were introduced. The performance failure conditions do not apply.

Full details: Security And Secret Handling

Explanation

PASSED. The PR changes only model names in documentation, schema examples, error examples, and a docstring code example. The diff adds no secrets, tokens, credentials, endpoint handlers, authorization logic, query construction, command execution, path handling, WebSocket messages, or logging changes. No Kubernetes Secret or RH secret manifests are changed.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
✨ Simplify code
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@tisnik
tisnik merged commit 9794767 into lightspeed-core:main Oct 19, 2026
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants