DEMO: new CLI keeps Korean litesvm table (rebuts #1756 attribution) - #2
Open
cherkanovart wants to merge 1 commit into
Open
DEMO: new CLI keeps Korean litesvm table (rebuts #1756 attribution)#2cherkanovart wants to merge 1 commit into
cherkanovart wants to merge 1 commit into
Conversation
…intact (4 rows), drift fixed 50->49
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this shows
Runs the new `@lingo.dev/cli@1.10.1` (same version as Solana CI `@latest`) with Solana's solana-foundation#1754 migrated config against the drifted Korean `testing-with-litesvm-loader/index.mdx` (the pre-solana-foundation#1756 state, table present, 50 blocks) on a clone of their engine.
Result
The 4-row `### 일반적인 오류` (Common Errors) table is fully preserved and the block drift is repaired (50 -> 49). The new CLI does NOT drop the table.
Why this matters
Solana solana-foundation#1756 (which deleted this table) was attributed to the new CLI. It was actually the tail of the OLD CLI run:
The new CLI's server-side MDX assembler builds the target from the English source, so a source-present block cannot be silently dropped.