Repository navigation
TPT-4731: Fix nested CLI arguments for schemas without an explicit type - #931
Open
zliang-akamai wants to merge 4 commits into
Open
zliang-akamai wants to merge 4 commits into
zliang-akamai wants to merge 4 commits into
Conversation
zliang-akamai
requested review from
mawilk90 and
yec-akamai
and
a balanced review from Copilot
and removed request for
a team
October 12, 2026 15:11
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
JSON-formatted composed fields are incorrectly expanded instead of remaining raw parent arguments.
1 open finding
What changed in this PR
Fixes dotted CLI argument generation for composed schemas lacking type: object.
Changes:
- Detects nested properties through schema aggregation.
- Adds regression coverage and updates fixture/documentation.
| File | Description |
|---|---|
linodecli/baked/request.py |
Expands implicit composed objects. |
tests/unit/test_request.py |
Verifies exact generated arguments. |
tests/fixtures/operation_with_one_ofs.yaml |
Tests a composition without explicit object type. |
linodecli/baked/AGENTS.md |
Documents nested composition handling. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
zliang-akamai
marked this pull request as draft
October 12, 2026 15:23
zliang-akamai
marked this pull request as ready for review
October 12, 2026 15:53
zliang-akamai
marked this pull request as draft
October 12, 2026 15:56
zliang-akamai
marked this pull request as ready for review
October 12, 2026 18:29
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

📝 Description
Expand nested request arguments and response attributes for composed schemas without an explicit
type: object, fixing flags such as--details.host. Preserve JSON-formatted fields and explicit scalar/array handling, with regression coverage.✔️ How to Test
Focused regression tests:
Command it fixes:
Creating a bucket in
us-miawith an OBJ key with read/write access to the bucket first.