Repository navigation
Conversation
Render nullable types as a readable union in database configuration tables. Cover Valkey output without changing non-nullable types. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
What does this PR do and why is this change necessary?
Adds integration test coverage for Valkey Managed Databases, including engine and type discovery, database listing and viewing, engine configuration, credentials and SSL, suspend/resume, patching, and snapshot-based fork/restore.
Adds table output handling for
valkey-config-view, including readable formatting for nullable configuration parameter types ( backup_minute, backup_hour, valkey_memory_policy etc. ), such asinteger | nullorstring | null. This is required as Valkey’s config schema includes nullable parameter types represented as lists, such as ["integer", "null"] .The new formatting helper renders those as
integer | null. I modeledadd_param_rowthat now applies that formatting only when the Valkey handler opts in otherwise its default preserves the existing type formatting for PostgreSQL and MySQL.✔️ How to Test
What are the steps to reproduce the issue or verify the changes?
Set
LINODE_CLI_TOKENto a token for an account that can create Managed Databases. The integration tests create and delete live database resources. Snapshot restore is skipped by default; setRUN_LONG_TESTS=Trueto run it.How do I run the relevant unit/integration tests?
make test-unit— passed.make test-int TEST_SUITE=database TEST_CASE=valkey TEST_ARGS='-v'— 10 passed, 1 skipped, 17 deselected.