Repository navigation
test(gax): use FakeApiClock and RecordingScheduler in ScheduledRetryingExecutorTest - #31
Open
lqiu96 wants to merge 1 commit into
Conversation
…elpers Use FakeApiClock and RecordingScheduler in ScheduledRetryingExecutorTest for deterministic, sleep-free retry tests without modifying existing asynchronous in-flight test methods. Refactor RecordingScheduler to extend ScheduledThreadPoolExecutor directly, eliminating Mockito dependencies and strict-stubbing friction. Add Javadoc documentation for FakeApiClock and RecordingScheduler. Fixes googleapis#13535
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is stacked on top of PR googleapis#14705 (branch
fix/gax-direct-retrying-executor-fake-clock-14625). It updatesScheduledRetryingExecutorTestto useFakeApiClockandRecordingScheduler, eliminating real-timeThread.sleepandScheduledThreadPoolExecutorwall-clock delays from retry tests while keeping asynchronous state and cancellation tests untouched.Changes
RecordingSchedulerto extendScheduledThreadPoolExecutordirectly with a single worker thread (CORE_POOL_SIZE = 1), eliminating Mockito dependencies andUnnecessaryStubbingExceptionunderMockitoExtension.FakeApiClockandRecordingSchedulerexplaining virtual time advancement, sleep recording, and why zero-delay delegation to a dedicated single worker thread is required to preserve asynchronous callback registration inCallbackChainRetryingFuture.java.time.DurationinRecordingScheduler.javaand remove fully qualified names.ScheduledRetryingExecutorTestwith dedicatedfakeClockandrecordingSchedulerfixtures for deterministic retry algorithm tests without touching the sharedscheduledExecutorServiceused by intermediate-state and cancellation tests.Fixes googleapis#13535