Repository navigation
P10.9H — IEC-aware diagnosis: same-NIC IP aliases + late BRCB continuity context - #534
Merged
masarray merged 2 commits intoOct 12, 2026
Conversation
… late BRCB anomalies
masarray
merged commit Oct 12, 2026
1439936
into
fix/512-goose-event-header-alignment
15 checks passed
This was referenced Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Genuine verified usability defect + IEC 61850 causal diagnostics, tightly scoped
2026-10-12 field BCUGE Discovery report (engine d700b0df) has 67/67 displayed, 6/6 exact static RCBs, 0 cyclic polling, 80 reports, 27 BRCB sequence discontinuities and BufOvfl=2. Crucially, CSWI GW experienced a fresh SqNum 4→1 reset 48.6 seconds after report activation, not only at startup. It also names five "matching adapters" although all matching IPv4 addresses (192.16.1.13, .33, .115, .158, .175) are aliases on one KM_Test adapter, and the IED target 192.16.1.33 is an address installed on the same PC. The old route diagnostic falsely advised operators to disable adapters or change metrics.
Actual application fix (no new engine revision)
ExplainIpv4Routenow correctly distinguishes multi-IP/same NIC, same-host address (possible local MMS simulator), real competing NICs even when their friendly names match, and gateway-routed reachability. Preserve full per-address network matrix, actual OS-chosen UDP source, and TCP probe; diagnosis is explicit that Windows route remains authoritative. No gratuitous adapter disabling advice.ExplainBrcbContinuityreuses existing bounded per-RCB timestamps/sequence/GI/BufOvfl evidence to expose confirmed GI-tagged discontinuities vs discontinuities without confirmed GI reason; output precise last anomaly ms after RCB start and recognize late >5-second recurrence (rather than erroneously labelling "startup-only"). No inference of event loss, harmless GI resets, on-wire order or root cause; missing/reversed timestamps remain UNKNOWN.Services/DiagnosticReportBuilder.csandtests/ARSAS.Tests/ContextAwareIec61850DiagnosisTests.cs. No change to MMS transport, engine pinned SHAd700b0df741b466afb8abe6cee1d70b1619d7b4d, data/report decoder, GI, RCB, SCL, GOOSE, cyclic polling, UI control or main.Gates and limitations
Source base P10.9G verified ARSAS staging
80d1a894b1c909b61ccbe36440528c5ef32ee388. Reuse existing canonical Windows Build, native bridge, report regression, SCL/R7, IO/SV, Field Capture, installer and mainline/physical-provenance workflow gates. Do not create redundant workflows or rerun jobs gratuitously. Merge only after complete exact-head all-green, immutable checkpoint + guarded non-force FF. Parent PR #512 remains draft, mains/release untouched.BCUGE BRCB server/wire anomaly #520 stays OPEN. This PR makes ARSAS context aware and eliminates a real false-positive network troubleshooting instruction, but does not claim the GE/same-PC simulator's 27 SqNum discontinuities and 2 BufOvfl were fixed. Physical SOE completeness requires causally independent evidence, not suppressing warnings or repeating identical two diagnostic logs.