Repository navigation
P3-A1: native ARStack Studio binary profile deployment and installer candidate - #151
Merged
Merged
Conversation
Expose C++-compiled device-profile bytes through SclProfileModel, require PROFILE-BINARY-V1 in native identity/firmware contracts, and add firmware BINSTATUS recovery introspection. No web control path.
Replace legacy text batch deployment in DeviceController with BINSTATUS recovery, stale-stage abort, transaction-exact chunk ACKs, BINCOMMIT, and PROFILE SHOW identity/generation verification. Increase bounded sync timeout for sequential acknowledgements.
Add explicit native C++/firmware source gate, keep browser control surface out of Studio build, and update Studio docs to the current v0.1.1 installer release.
This was referenced Oct 7, 2026
Make BINABORT/BINCOMMIT acknowledgements transaction-exact and refresh the bounded Studio sync deadline only on validated protocol progress, preventing stale serial responses from completing a newer deployment.
Assert stale ACKs cannot arm or advance profile generation while allowing SmartSessionController to retain its production retry policy.
masarray
marked this pull request as ready for review
October 7, 2026 09:31
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracks #36, #33 and recovery #139. Supersedes closed #150 (deprecated browser/WebSerial control path).
Correct product path
ARStack Studio Qt/C++ is the canonical operator surface and the Windows installer is the release artifact. This PR wires the accepted #146/#149 binary V1 profile contract into the native Studio pipeline:
SCL/CID -> native SclProfileModel -> SvPublisherProfile -> compile_esp32p4_device_profile -> SvDeviceProfileBinaryCodec -> native DeviceController -> ESP32-P4 firmware.
Changes
BINSTATUS -> stale BINABORT if needed -> BINBEGIN -> bounded 48-byte BINCHUNK + exact ACK -> BINCOMMIT -> PROFILE SHOW verification.
Acceptance
Keep Draft until exact-head C++/Qt/ESP/security + ARStack Studio Release workflows are green. The desired test artifact is the existing
arstack-studio-windows-x64package containingARStack-Studio-0.1.1-win-x64-setup.exeplus the matched firmware bundle. No web artifact is an acceptance output.Physical 4000/4800 fps, canonical VLAN/multicast capture and hardware timestamp evidence remain separate bench acceptance gates.
Architecture audit after native-path correction
main@6255d88fe7216dbfa93999a27364958c853c6ca0; branch is not rebasing over or reviving the deprecated browser path.requestProfileSync()carries no profile payload from QML; SmartSessionController reads the C++ SclProfileModel directly.SvDeviceProfileBinaryCodecis used by native Studio and firmware; there is no JS serializer/CRC/model.runtime_profile_commit()while STOPPED.Release hygiene note: PR CI currently still packages version label
0.1.1; do not publish/tag this branch as a new public release under that same version. The CI artifact can be used as an exact-head bench candidate; semantic versioning for the next public release is a separate decision.