Repository navigation
Conversation
| const showNextDone = props.buttonPattern !== "none"; | ||
|
|
||
| return ( | ||
| <Modal visible={visible} transparent={props.showMode === "popup"}> |
There was a problem hiding this comment.
The old Modal here, was transparent only for 'popup' - I guess for the fullscreen mode it might have had a default background.
Let's see if we can either add a transparent prop to the new MxOverlay or have an opaque backdrop for fullscreen mode.
Perhaps we can add also an assertion test for this since we're here.
| : undefined; | ||
|
|
||
| return ( | ||
| <Modal |
There was a problem hiding this comment.
Consider adding the supportedOrientation prop here, to account for similar issues like the one we had for BottomSheet on iOS.
| const finish = (): void => { | ||
| if (!visible) { | ||
| setMounted(false); | ||
| moveFocusTo(returnFocusRef); |
There was a problem hiding this comment.
This moveFocusTo might be a bit too close after the async state change of setMounted. I suspect that moveFocusTo might get called while the native modal is still on screen.
Consider moving the moveFocusTo call in a separate useEffect, i.e. to run after the modal is truly gone/unmounted.
|
|
||
| ### Changed | ||
|
|
||
| - The IntroScreen is now presented through the shared MxOverlay component. Its appearance and behaviour, including blocking the Android back button, are unchanged. |
There was a problem hiding this comment.
Reminder to also bump the version as well.
3 participants
Checklist
[XX-000]: description)? ✅ ❌Feature specific
Please remove unnecessary emojis and sections and this comment before proceeding
This PR contains
What is the purpose of this PR?
...
Relevant changes
Please add a high level explanation of what was changed and how the initial problem was solved
What should be covered while testing?
...
Extra comments (optional)
Please add extra comments or delete the section if not required