Repository navigation
fix: return an error when the home directory cannot be determined - #584
Open
Sarthak-Shreshtha01 wants to merge 1 commit into
Open
Sarthak-Shreshtha01 wants to merge 1 commit into
Sarthak-Shreshtha01 wants to merge 1 commit into
Conversation
Signed-off-by: Sarthak <sarthakshreshtha345@gmail.com>
Sarthak-Shreshtha01
requested review from
Harsh4902,
lbroudoux and
yada
as code owners
October 13, 2026 18:53
|
could we resolve the default config path after Cobra parses flags? As written, if home-directory resolution fails while NewCommand() is being built, an explicit --config override may not get a chance to work. Returning a clear error is still a good fallback when no override is supplied. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DefaultConfigDir now returns an error when the home directory cannot be found and MICROCKS_CONFIG_DIR is not set, instead of an empty path that made the config file resolve to the current directory. The related tests pass, including the new TestDefaultPathsWithoutHomeDir.
Fixes #583