Repository navigation
refactor(hidi): remove migrated main tool resources - #3111
Draft
Gavin Barron (gavinbarron) wants to merge 1 commit into
Draft
Gavin Barron (gavinbarron) wants to merge 1 commit into
Gavin Barron (gavinbarron) wants to merge 1 commit into
Conversation
Follow accepted OpenAPI.NET.OData main migration PR884. Preserve current library ESRP/signing/feed/version-check and GitHub release infrastructure; point hidi documentation to its new home. Cleanup acceptance remains gated on publisher handoff readiness. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c631d217-9378-4cee-8c7e-761043ff3ae5
Code Coverage OverviewLanguages: C# C# / code-coverage/dotnetThe overall line coverage in commit bfc6e48 in the Show a line coverage summary of the most impacted files.
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Pull Request
Description
Remove the main-branch Hidi resources from OpenAPI.NET after the history-preserving migration merged into OpenAPI.NET.OData. Hidi remains discoverable through links to its new repository; the OpenAPI.NET core and YAML reader libraries retain their current code, versions, tests, signing, and release infrastructure.
Draft only: do not merge until the destination's signed Hidi payload is preserved inside the tool package and actual signed-artifact readiness is revalidated. Destination authorization has cleared and signing tasks succeeded, but downloaded artifacts exposed an unsigned Hidi DLL inside both branches' NuGet tool packages. Correcting and verifying that payload is now the release-handoff gate. This PR does not publish packages or images, change destination publishing flags, or authorize release resources.
Type of Change
Related Issue(s)
11e882530c3976ac1e563b28e264dcea5724e94f.c8e64dc3f486b4a2cfbc250e81628b47b9514b35; reviewed headc6717bb88f28bb4bed2ff7ae17313056d7ab9a92retained the library GitHub release-edit job.Changes Made
create_github_releasewithaction: edit. The remaining deploy jobs are tag-only; the removed Docker job was the only main/nightly deploy consumer.3.10.2, shared release scripts, security/feed configuration, historical changelog, commit-scope examples, and unrelated documentation. No dependency upgrades or history rewriting.Testing
Validation was performed by the parent migration session against cleanup commit
bfc6e487631ffa8bb46d31c8778f96ddbd4c73e5.e1a75437b76ebfc7c9eb446e9fd0b59a21afb14b:dotnet test --solution Microsoft.OpenApi.slnx -c Releasepassed 1970/1970, including 69 Hidi tests.git diff --checkpassed for this 53-file cleanup.dotnet build Microsoft.OpenApi.slnx -c Release -v quietpassed, 0 warnings and 0 errors.dotnet test --solution Microsoft.OpenApi.slnx -c Release --no-build -v minimalpassed 1901/1901, exactly the baseline minus the 69 migrated Hidi tests.dotnet pack src\Microsoft.OpenApi\Microsoft.OpenApi.csproj -c Release --no-build -o C:\Users\gavinbarron\.copilot\session-state\c631d217-9378-4cee-8c7e-761043ff3ae5\files\source-main-cleanup-packages --include-symbols --include-source /p:SymbolPackageFormat=snupkg -v quietpassed.dotnet pack src\Microsoft.OpenApi.YamlReader\Microsoft.OpenApi.YamlReader.csproj -c Release --no-build -o C:\Users\gavinbarron\.copilot\session-state\c631d217-9378-4cee-8c7e-761043ff3ae5\files\source-main-cleanup-packages --include-symbols --include-source /p:SymbolPackageFormat=snupkg -v quietpassed. The package directory contains only the four core/YAML3.10.2.nupkg/.snupkgfiles, with no Hidi package.go run github.com/rhysd/actionlint/cmd/actionlint@v1.7.7 -shellcheck= -pyflakes= .github\workflows\codeql-analysis.ymlpassed.EsrpCodeSigning@6inputs are unchanged;deploy_yaml_readeris identical;deploy_libdiffers only by removal of the obsolete Hidi exclusion;create_github_releasediffers only by removal of the Hidi executable asset attachment. Shared signing key, version props, feed/organization/ProductBin variables, feed authentication, version-check helper, and historical changelog remain unchanged. No active Hidi graph entries or files remain.No new library behavior is introduced, so no new library tests or integration tests were added. Only the migrated Hidi tests are removed; the remaining suites pass unchanged.
Checklist
Versions applicability
See the contributing guidelines for more information about how patches are applied across multiple versions.
Additional Notes
Accepted destination follow-ups: Docker feed authentication microsoft/OpenAPI.NET.OData#890 merged as
a86a14613e4e1cfff966aed55248a4f0e06b658b; Hidi-only NuGet ESRP/private-feed idempotency/package-symbol handoff microsoft/OpenAPI.NET.OData#891 merged asdb4c6dc68c72aa8ab949c1ddfa13004ceaa05446. Physical Pester corrections merged via microsoft/OpenAPI.NET.OData#895 (support/v2,3aae8d6f1e0511501e93385ebeabe5359084532e) and microsoft/OpenAPI.NET.OData#896 (main,cb766cb7a16925d1967f92ed9e48a583eaa934aa). Independent Hidi version/tag routing merged via microsoft/OpenAPI.NET.OData#898 (support/v2,7ab04f294e34d397e47dc4a99e54d7ed6724e82f) followed by microsoft/OpenAPI.NET.OData#897 (main,0b8e521a1c7fc8be74d9070ab7229d66da5d9549). These code/review follow-ups are accepted. The migration coordinator verified canonical ancestry, common stock release configuration, tag guards, exact OData packaging, and disabled publication on both accepted targets.Publisher-handoff gate remains: signed tool payload correction and revalidation. Keep this PR in draft. Authorization for destination official Hidi pipeline 759 was cleared externally; the current publication-disabled runs 248624 (support/v2) and 248625 (main) completed signing tasks successfully. The migration coordinator downloaded the actual artifacts and verified the NuGet package and executable signatures, but the Hidi DLL inside the NuGet tool package is unsigned on both branches. On main, its hash exactly matches the pre-sign log hash despite the signing log confirming a signed staging DLL. This is signed-payload loss during packing, not an outstanding authorization failure; successful signing tasks and signed package envelopes alone do not prove payload readiness.
Separate destination follow-ups are correcting the actual
PackAsToolsigned payload and adding a fail-closed guard through new normal PRs. Before source cleanup can land, those corrections must be accepted and new official artifacts must verify the signed Hidi DLL inside the package, as well as package/executable signatures and destination signing/feed/release/container readiness. The coordinated publisher cutover remains required. Destination publication switches remain false; no real release or publication occurred. Do not mark this source PR ready, enable auto-merge, or merge it based on the earlier successful signing-task results.Stock Release Please generated separate open Hidi version PRs microsoft/OpenAPI.NET.OData#901 (v2.13.0) and microsoft/OpenAPI.NET.OData#902 (v3.11.0), independently of root library versions. Do not merge those version PRs or create releases as part of this cleanup. No publisher activation, resource grant, or real publication is authorized by this PR.
This change is scoped only to main cleanup. The support/v2 cleanup is already accepted separately; support/v1 and the overall migration's publication handoff are not completed by this PR.