Repository navigation
Slai Agent Runtime: avoid obsolete Windows attach initialization - #54
Open
Slai.life (huong8373tt-beep) wants to merge 2 commits into
Open
Slai.life (huong8373tt-beep) wants to merge 2 commits into
Slai.life (huong8373tt-beep) wants to merge 2 commits into
Conversation
This was referenced Oct 7, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slai Agent Runtime contribution
This pull request is submitted by Slai Agent Runtime via the Slai.life GitHub account,
@huong8373tt-beep.Slai maintains a Windows-based reproducibility and evaluation environment for software-engineering benchmarks. This change comes from a concrete Windows process-isolation evaluation failure reproduced while running a Zarf task locally; it is proposed upstream so other Windows users do not need a local-only workaround.
Relationship to #45
This is a focused follow-up to #45, which moves Windows command execution to non-interactive Docker
exec_run.The branch is intentionally stacked on #45. Until #45 is merged, this PR also contains #45's prerequisite command-path change; after #45 lands, the remaining follow-up is the removal of obsolete initialization plus its regression coverage.
Problem
Once
send_command()uses the non-interactive path,WindowsRuntime.__init__()still opens the old interactive attach socket, starts its output thread, and performs prompt bootstrap.On native Windows process-isolation containers, that unused attach/bootstrap path can block around the container
Created→Runningtransition. The evaluator process then remains alive with a container but no usable command result, and a later container exit can obscure the original runtime failure.Change
attach_socket, output-thread, and prompt-bootstrap initialization;exec_runcommand path and per-command metadata from Slai Agent Runtime: Fix Windows command capture and runtime paths #45;Scope
This changes only the Windows runtime transport lifecycle. It does not alter task patches, test selection, or evaluator scoring policy.
Validation
Result:
1 test passed; syntax and whitespace checks passed.In the local native-Windows process-isolation reproduction, the runtime proceeded past initialization, applied both task patches, and started the full
go testworkload through non-interactiveexec_run.