[api] Add hasTrailingComma getter in the RemoteNodeList class - #63957
Open
Tom Mrazauskas (mrazauskas) wants to merge 4 commits into
Open
[api] Add hasTrailingComma getter in the RemoteNodeList class#63957Tom Mrazauskas (mrazauskas) wants to merge 4 commits into
hasTrailingComma getter in the RemoteNodeList class#63957Tom Mrazauskas (mrazauskas) wants to merge 4 commits into
Conversation
Signed-off-by: mrazauskas <tom@mrazauskas.de>
typescript-automation
Bot
added
the
For Uncommitted Bug
Copilot started reviewing on behalf of
Tom Mrazauskas (mrazauskas)
August 22, 2026 09:31
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Adds RemoteNodeList.hasTrailingComma serialization and decoding support.
Changes:
- Extends node records with trailing-comma metadata.
- Bumps the protocol to version 8.
- Generates a getter for remote node lists.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
tsc/internal/api/encoder/encoder.go |
Encodes trailing-comma metadata. |
tools/scripts/tsc/generate-encoder.ts |
Generates the new getter. |
packages/typescript/src/api/node/protocol.ts |
Updates protocol layout and version. |
packages/typescript/src/api/node/node.generated.ts |
Reads the serialized metadata. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Tom Mrazauskas (mrazauskas)
marked this pull request as draft
August 22, 2026 09:35
Signed-off-by: mrazauskas <tom@mrazauskas.de>
Signed-off-by: mrazauskas <tom@mrazauskas.de>
Tom Mrazauskas (mrazauskas)
marked this pull request as ready for review
August 22, 2026 11:20
| // | 16-20 | uint32 | Node index of parent | | ||
| // | 20-24 | | Node data | | ||
| // | 24-28 | uint32 | Node flags | | ||
| // | 28-32 | uint32 | HasTrailingComma (NodeList only; reserved/0 otherwise) | |
Contributor
Author
There was a problem hiding this comment.
By the way, flags is always hard-coded to 0 for NodeList. So another solution could be to move HasTrailingComma to that slot for NodeList instead of creating a new one. (The ordinary nodes do not need HasTrailingComma.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #63861
This PR adds
hasTrailingCommagetter in theRemoteNodeListclass.AI Assistance Disclosure: Claude Sonnet assisted in authoring this PR. I have reviewed and understand all changes.