Pin the Yarn bootstrap and add SHA-512 lock checksums - #14703
Merged
Sean McManus (sean-mcmanus) merged 3 commits intoAug 25, 2026
Merged
Conversation
Copilot started reviewing on behalf of
Sean McManus (sean-mcmanus)
August 25, 2026 00:24
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Pins the Yarn bootstrap install and strengthens dependency verification with SHA-512 integrity hashes.
Changes:
- Installs Yarn 1.22.22 using the existing pinned npm lockfile.
- Adds SHA-512 integrity values to all 932 Yarn lock entries.
- Documents the revised bootstrap process.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
Extension/package.json |
Uses the pinned bootstrap package for global Yarn installation. |
Extension/yarn.lock |
Adds SHA-512 checksums alongside SHA-1. |
Extension/readme.developer.md |
Documents pinned Yarn bootstrap behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Sean McManus (sean-mcmanus)
marked this pull request as ready for review
August 25, 2026 01:17
Colen Garoutte-Carson (Colengms)
approved these changes
Aug 25, 2026
…and-lock-checksums
Sean McManus (sean-mcmanus)
deleted the
seanmcm/devbox2-wsl/agent102/yarn-bootstrap-and-lock-checksums
branch
August 25, 2026 02:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two independent Yarn hardening changes, both using only supported package-manager behavior — no new scripts or custom tooling.
Extension/yarn.locknow carries SHA-512 integrity alongside the existing SHA-1 for all 932 entries, produced by Yarn's supportedyarn install --update-checksums. Yarn's bundledssriselects the strongest listed digest, so SHA-512 is the value actually enforced on install.npm run bootstrapnow installs Yarn from the already-present but previously unusedExtension/.yarn-bootstrap/package-lock.json, instead of re-resolvingyarn@1.22.22from the feed on every run with nothing pinning the result.This retains only the supported-package-manager portion of #14701, which was closed without merging.
Notes for reviewers
yarn.lockdiff is large but entirely mechanical. All 1864 changed lines areintegrityvalues; no package version, resolution URL, or dependency edge changed.integrity "sha1-… sha512-…", keeping both. Its bundledssripicks the strongest algorithm present, so SHA-512 is what gets verified. Verified directly: corrupting one entry's SHA-512 while leaving its SHA-1 correct makesyarn install --frozen-lockfilefail withIntegrity check failed.--force. With a warm treeyarn install --update-checksumsreportssuccess Already up-to-dateand changes nothing; with a warm cache it upgrades only some entries. A useful completeness check is that the count ofintegrity "sha1-… sha512-…"lines equals the totalintegrityline count (932).Extension/.yarn-bootstrap/{package.json,package-lock.json}already existed in the repository but were referenced by nothing. Its single entry keeps its SHA-1 value, which npm accepts.Validation
yarn install --frozen-lockfilesucceeds and leaves the lockfile unchanged.Integrity check failed).bootstrap:yarnrun clean and yield Yarn1.22.22.yarn verify-yarn-lockpasses,yarn test-yarn-lockpasses, andgit diff --checkis clean.