Skip to content

Register LLVM source used by LLDB-MI - #14704

Merged
Sean McManus (sean-mcmanus) merged 2 commits into
mainfrom
seanmcm/devbox2-wsl/agent33/register-llvm-component
Aug 25, 2026
Merged

Register LLVM source used by LLDB-MI#14704
Sean McManus (sean-mcmanus) merged 2 commits into
mainfrom
seanmcm/devbox2-wsl/agent33/register-llvm-component

Conversation

@sean-mcmanus

Copy link
Copy Markdown
Contributor

Summary

Register the exact llvm-project revision cloned by the LLDB-MI build, normalize the Component Governance manifest to its current schema, and add a focused check that keeps both LLDB-MI build inputs synchronized with the manifest.

This PR was investigated and created by GitHub Copilot in VS Code. Any message starting with ✨Copilot: was sent by Copilot.

Why this matters

The LLDB-MI build consumes two independently pinned Git repositories: llvm-project supplies the LLVM and LLDB source used to create the build environment, while lldb-mi supplies the executable source. The manifest currently registers only lldb-mi, so the component inventory describes only one of the two source inputs used to produce the artifact.

Component inventory is not limited to files copied verbatim into the VSIX. Source fetched and compiled during an artifact build must be associated with the exact revision that was consumed. Registering llvm-project at 0d44201451f03ba907cdb268ddddfc3fa38a0ebd closes that gap without changing the build or the existing lldb-mi registration.

The build template already says its two repository/hash pairs must match the manifest, but comments cannot prevent drift. The new dependency-free validator compares both pairs, accepts the manifest's canonical URL spelling without the optional .git suffix, and fails CI when a registration is missing or stale. It runs before dependency installation in the existing compile-and-test workflow.

Open PR #11566 changes only the existing lldb-mi pin. It remains independent; if it lands, the validator will require its build and manifest hashes to be updated together.

Validation

  • npm run test-lldb-mi-component-manifest
  • npm run verify-lldb-mi-component-manifest
  • npm run test-yarn-lock
  • npm run verify-yarn-lock
  • Component manifest SchemaStore validation
  • Workflow and LLDB-MI template YAML parsing
  • git diff --check

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Registers LLVM as an LLDB-MI build dependency and adds CI validation to prevent manifest pin drift.

Changes:

  • Normalizes and expands the Component Governance manifest.
  • Adds a dependency-free manifest validator with focused tests.
  • Runs validation before dependency installation.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Extension/package.json Adds validator scripts.
Extension/cgmanifest.json Registers the pinned LLVM revision.
Extension/.scripts/verifyLldbMiComponentManifest.test.mjs Tests manifest synchronization.
Extension/.scripts/verifyLldbMiComponentManifest.mjs Validates repository and commit pairs.
.github/workflows/job-compile-and-test.yml Runs validation in CI.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@sean-mcmanus
Sean McManus (sean-mcmanus) marked this pull request as ready for review August 25, 2026 01:25
@sean-mcmanus
Sean McManus (sean-mcmanus) requested a review from a team as a code owner August 25, 2026 01:25
@sean-mcmanus
Sean McManus (sean-mcmanus) merged commit 659f11c into main Aug 25, 2026
5 checks passed
@sean-mcmanus
Sean McManus (sean-mcmanus) deleted the seanmcm/devbox2-wsl/agent33/register-llvm-component branch August 25, 2026 02:59
@github-project-automation github-project-automation Bot moved this from Pull Request to Done in cpptools Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants