Register LLVM source used by LLDB-MI - #14704
Merged
Sean McManus (sean-mcmanus) merged 2 commits intoAug 25, 2026
Merged
Conversation
Copilot started reviewing on behalf of
Sean McManus (sean-mcmanus)
August 25, 2026 01:17
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Registers LLVM as an LLDB-MI build dependency and adds CI validation to prevent manifest pin drift.
Changes:
- Normalizes and expands the Component Governance manifest.
- Adds a dependency-free manifest validator with focused tests.
- Runs validation before dependency installation.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
Extension/package.json |
Adds validator scripts. |
Extension/cgmanifest.json |
Registers the pinned LLVM revision. |
Extension/.scripts/verifyLldbMiComponentManifest.test.mjs |
Tests manifest synchronization. |
Extension/.scripts/verifyLldbMiComponentManifest.mjs |
Validates repository and commit pairs. |
.github/workflows/job-compile-and-test.yml |
Runs validation in CI. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Sean McManus (sean-mcmanus)
marked this pull request as ready for review
August 25, 2026 01:25
Colen Garoutte-Carson (Colengms)
approved these changes
Aug 25, 2026
Sean McManus (sean-mcmanus)
deleted the
seanmcm/devbox2-wsl/agent33/register-llvm-component
branch
August 25, 2026 02:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Register the exact
llvm-projectrevision cloned by the LLDB-MI build, normalize the Component Governance manifest to its current schema, and add a focused check that keeps both LLDB-MI build inputs synchronized with the manifest.Why this matters
The LLDB-MI build consumes two independently pinned Git repositories:
llvm-projectsupplies the LLVM and LLDB source used to create the build environment, whilelldb-misupplies the executable source. The manifest currently registers onlylldb-mi, so the component inventory describes only one of the two source inputs used to produce the artifact.Component inventory is not limited to files copied verbatim into the VSIX. Source fetched and compiled during an artifact build must be associated with the exact revision that was consumed. Registering
llvm-projectat0d44201451f03ba907cdb268ddddfc3fa38a0ebdcloses that gap without changing the build or the existinglldb-miregistration.The build template already says its two repository/hash pairs must match the manifest, but comments cannot prevent drift. The new dependency-free validator compares both pairs, accepts the manifest's canonical URL spelling without the optional
.gitsuffix, and fails CI when a registration is missing or stale. It runs before dependency installation in the existing compile-and-test workflow.Open PR #11566 changes only the existing
lldb-mipin. It remains independent; if it lands, the validator will require its build and manifest hashes to be updated together.Validation
npm run test-lldb-mi-component-manifestnpm run verify-lldb-mi-component-manifestnpm run test-yarn-locknpm run verify-yarn-lockgit diff --check