Verify signed LLDB-MI macOS artifacts - #14705
Draft
Sean McManus (sean-mcmanus) wants to merge 10 commits into
Draft
Verify signed LLDB-MI macOS artifacts#14705Sean McManus (sean-mcmanus) wants to merge 10 commits into
Sean McManus (sean-mcmanus) wants to merge 10 commits into
Conversation
Copilot started reviewing on behalf of
Sean McManus (sean-mcmanus)
August 25, 2026 01:17
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Adds post-sign validation for packaged macOS LLDB-MI artifacts.
Changes:
- Names the signing job and adds a dependent verification job.
- Validates archive layout, architecture, signature chain, entitlements, and tamper rejection.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…gent109/verify-lldb-mi-signatures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds post-sign verification for the final macOS x86_64 and arm64 LLDB-MI archives. The verification checks the expected payload path and architecture, requires a valid strict non-ad-hoc code signature with an authority chain, confirms the debugger entitlements are unchanged, and proves a modified binary is rejected.
Both producers select native Python 3.11 because the pinned LLVM 13 build still requires
distutils, which newer hosted-image Python versions no longer provide. The arm64 producer now uses the supportedmacOS-15-arm64hosted image instead of the inactive private M1 pool. The pipeline explicitly selects each Python architecture, validates the PATH-selected interpreter before the expensive build, and binds LLVM's Python discovery to that interpreter and itssys.prefix.The pinned LLVM source also receives three upstream compatibility fixes:
cstdioheader whereSBFiledeclares itsFILE *constructor, as required by current Xcode headers.FileSPoutput typemap compatible with SWIG 4.1 and later move semantics.The pinned lldb-mi project declares a CMake 3.4 policy level. Its configure step now supplies CMake 4's documented external minimum policy version of 3.5 and exits immediately on configuration failure instead of falling through to a misleading missing
build.ninjaerror.Why
The build applies an ad-hoc signature to carry debugger entitlements before MicroBuild replaces it. A successful signing task alone does not prove that the published ZIP contains the intended replacement signature or that the entitlements survived signing and packaging. Verifying the final artifacts catches signing-target, packaging, and post-sign corruption regressions before release.
Validation
bash -nand ShellCheck on the expanded validation scripts and compatibility blocks.git diff --check.20260825.9is validating both final signed artifacts on the current merged result.