Repository navigation
Fix RangeError - #9040
Merged
Merged
Fix RangeError#9040
Conversation
Fixes #9023
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Failed-page recovery leaves pagination counters inconsistent, potentially dropping cached PRs from other remotes.
1 open finding
What changed in this PR
Fixes unbounded Copilot PR pagination and improves polling recovery.
Changes:
- Explicitly advances pagination and detects stalled results.
- Adds cumulative pagination progress and deduplicates PRs.
- Adds polling error handling and regression tests.
| File | Description |
|---|---|
src/view/prsTreeModel.ts |
Corrects pagination and deduplicates results. |
src/github/folderRepositoryManager.ts |
Tracks cross-repository pagination progress. |
src/github/copilotPrWatcher.ts |
Logs failures and safely resumes polling. |
src/test/view/prsTreeModel.test.ts |
Covers pagination, recovery, and scheduling. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
Alex Ross (alexr00)
marked this pull request as draft
October 8, 2026 15:20
auto-merge was automatically disabled
October 8, 2026 15:20
Pull request was converted to draft
Alex Ross (alexr00)
marked this pull request as ready for review
October 8, 2026 15:33
Alex Ross (alexr00)
enabled auto-merge (squash)
October 8, 2026 15:33
Logan Ramos (lramos15)
approved these changes
Oct 8, 2026
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
It changes shared pagination behavior used beyond Copilot polling and warrants final human validation.
0 open findings
1 resolved since last review
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9023