Skip to content

No checkboxes in commits subtree - #9041

Merged
Alex Ross (alexr00) merged 1 commit into
mainfrom
alexr00/protective-shark
Oct 8, 2026
Merged

Alex Ross (alexr00) merged 1 commit into
mainfrom
alexr00/protective-shark

Conversation

@alexr00

Copy link
Copy Markdown
Member

Fixes #340498

Copilot AI balanced review requested due to automatic review settings October 8, 2026 15:14
@alexr00
Alex Ross (alexr00) enabled auto-merge (squash) October 8, 2026 15:15
@alexr00 Alex Ross (alexr00) self-assigned this Oct 8, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused implementation covers both layouts and includes regression tests preserving existing behavior.

0 open findings

What changed in this PR

Prevents checkboxes from appearing beneath commit nodes while preserving them in normal file trees.

Changes:

  • Adds explicit checkbox visibility controls to file and directory nodes.
  • Disables checkboxes throughout commit subtrees.
  • Adds coverage for tree and flat layouts.
File Description
src/​view/​treeNodes/​fileChangeNode.ts Controls file checkbox visibility.
src/​view/​treeNodes/​directoryTreeNode.ts Propagates checkbox visibility through directories.
src/​view/​treeNodes/​commitNode.ts Disables commit-subtree checkboxes.
src/​test/​view/​treeNodes/​commitNode.test.ts Tests commit and regular-tree behavior.

🧠 Review effort: Balanced


Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.

@alexr00
Alex Ross (alexr00) merged commit 9b49d96 into main Oct 8, 2026
7 checks passed
@alexr00
Alex Ross (alexr00) deleted the alexr00/protective-shark branch October 8, 2026 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants