Repository navigation
Fix "checkout main" on restored PR webview - #9045
Draft
Alex Ross (alexr00) wants to merge 1 commit into
Draft
Alex Ross (alexr00) wants to merge 1 commit into
Alex Ross (alexr00) wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The manager transition is consistently implemented and covered across restoration, ownership, and checkout scenarios.
0 open findings
What changed in this PR
Ensures restored PR webviews can transition from remote-only access to the matching local repository manager.
Changes:
- Adds lazy remote-to-local manager upgrades.
- Preserves repository ownership and listener routing.
- Adds coverage for restoration, checkout, and manager resolution.
| File | Description |
|---|---|
src/github/issueOverview.ts |
Adds lazy manager upgrading. |
src/github/pullRequestOverview.ts |
Routes checkout operations through the selected local manager. |
src/github/overviewRestorer.ts |
Restores panels with a remote-only manager. |
src/github/folderRepositoryManagerResolver.ts |
Exposes remote-only manager retrieval. |
src/github/externalUriOpener.ts |
Moves manager resolution into error handling. |
src/test/github/pullRequestOverview.test.ts |
Tests upgrading, ownership, and checkout behavior. |
src/test/github/overviewRestorer.test.ts |
Verifies remote-only restoration. |
src/test/github/issueOverview.test.ts |
Tests issue-panel manager upgrades. |
src/test/github/folderRepositoryManagerResolver.test.ts |
Tests local and remote-only resolution. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.